Bug

There is bug in the plugin (Advanced Request For Quote  ). We are using the latest version, 1.19 in installation of NopCommerce 3.9 with several languages.
Steps to reproduce:
1. Open a form (/customerrequest)
2. Try to submit a form with empty fields - after postback it displays validation errors.
3. Change the language.
This results in error:
"
The parameters dictionary contains a null entry for parameter 'id' of non-nullable type 'System.Int32' for method 'System.Web.Mvc.ActionResult RFQForm(Int32, Int32)' in 'FoxNetSoft.Plugin.Misc.RFQ2.Controllers.RFQReadController'. An optional parameter must be a reference type, a nullable type, or be declared as an optional parameter.
Parameter name: parameters
"
Same happens when the URL is opened directly
/customerrequest
As I see it, the the problem happens because the URL is called without
any parameters.
This should not cause an exception.

I fixed it.
Plugin uses another URL format.
new URL
http://yourstore.com/customerrequest/1/1
old URL
http://yourstore.com/customerrequest?id=1&productId=1
I didn't changed release number.

I'm using nop version 3.9 and I've a problem in the plugin.

I've defined 12 buttons (all published) and only on a button I've associated a product.

In the product preview I see 12 buttons and not only one (the associated one).

The problem don't arise if i made the same but with manifacturers association

filippo.monti wrote:

the problem arise when the button is not associated with anything

I'll check it.

Support wrote:
Any news for me?

I checked plugin.
If you have empty list of products/categories/manufacturers for this 'Request button'. Plugin will add this button for ALL products. But if you added one association in the list of products/categories/manufacturers plugin will display this button only for this product or products from categories or products from manufacturers.

In old versions we used parameter 'Display for all products' but we removed it now.
Do you need another logic? Maybe I'll help you.

Yes please, we need another logic: if the button is not associated (empy list) the button should not be visible.

I.e. the button must be visible only for the associated elements (product/categorie/Manifacturers)

Thank's

Filippo

What will you do if you want to display button for ALL products?

If you want use a parameter on the button 'Display for all products' ok. Otherwise I'll add a product on the button if the button should be shown for the product.

Ok.
I have removed this button 'Display for all products'.
I'll think and answer you... maybe you are right....
Yes.
I'll add this button back and remove tabs for products/categories/manufacturers.

I'll answered you on this page.

I added new parameter 'Display for all products'
Download new release and replace ALL files (.SQL files too) restart your site. Plugin will upgrade itself. Try it.

I'll try.
Thank's a lot.
Filippo

The button is not diplayed. In the log I have:

2018.01.16 16:41:02:5267*******
RFQReadController. RFQ2_Widget. widgetZone=productdetails_bottom
2018.01.16 16:41:02:5557*******
RFQReadController. RFQ2_Widget. step 1.  productId=1413, categoryId=0, manufacturerId=0
2018.01.16 16:41:02:5937*******
RFQService. GetRFQButtons. productId=1413, categoryId=0, manufacturerId=0, storeId=1, languageId=2, AllowedCustomerRoleIds=1,3
-----------------> Error Invalid column name 'ForAllProduct'.

The column is present in [FNS_RFQRequestType] Table

Did you replace new SQL files from new plugin folder
These SQL files has TSQL script for adding new code...

Try to execute them manually.
1. Update119.RFQ2.sql
2. SqlServer.RFQ2.sql

Try and write me about result.

See SqlServer.RFQ2.sql

row 112-117

INSERT INTO #rfqRecordIdProduct (Id,LimitedToStores,SubjectToAcl)
select distinct A.Id,A.LimitedToStores,A.SubjectToAcl
from #tmpFNS_rfq_Record A WITH (NOLOCK),
  FNS_RFQProduct AP WITH (NOLOCK)
where A.Id not in (select Id from #rfqRecordIdProduct)
  and A.Id=AP.rfqRecordId and (AP.ProductId=@productId or AP.ForAllProduct=1)

The column in FNS_RFQProduct doesn't exists.

I am sorry... I did a bug ....

Download this file and execute new TSQL script SqlServer.RFQ2.sql
http://www.foxnetsoft.com/content/files/foxnetsoft.nopadvancedrfq.zip